[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35901] [bug#36132] [PATCH 2/2] installer: Show, don't Hide.
|
From: |
Ludovic Courtès |
|
Subject: |
[bug#35901] [bug#36132] [PATCH 2/2] installer: Show, don't Hide. |
|
Date: |
Tue, 11 Jun 2019 10:05:56 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hi,
Tobias Geerinckx-Rice <address@hidden> skribis:
> * gnu/installer/newt/user.scm (run-user-add-page): Change the input
> visibility checkbox's text to ‘Show’, and default to unchecked.
> * gnu/installer/newt/page.scm (run-input-page): Likewise.
> Rename INPUT-HIDE-CHECKBOX? argument to INPUT-SHOW-CHECKBOX?.
I think the argument should perhaps be ‘input-visibility-checkbox?’,
otherwise I find it a bit unclear (both before and after the patch
actually.)
Other than that LGTM, thank you!
Ludo’.