[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35930] haskell Setup.hs-related changes
From: |
Timothy Sample |
Subject: |
[bug#35930] haskell Setup.hs-related changes |
Date: |
Thu, 13 Jun 2019 11:57:01 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hi!
Ludovic Courtès <address@hidden> writes:
> Hi Robert,
>
> Robert Vollmert <address@hidden> skribis:
>
>> This primarily moves the substitution of missing Setup.hs files to
>> haskell-build-system. There was already duplicate code in a number
>> of packages to generated boilerplate Setup.hs, and I ran into a
>> couple more while trying to import some other packages.
>
> This looks like a welcome and harmless factorization; Timothy, Ricardo:
> WDYT?
>
> https://issues.guix.gnu.org/issue/35930
The first patch breaks “ghc-easyplot”.
I’m currently building some packages to test the other patches, and if
everything builds fine, they LGTM with some minor tweaks (which I’ve
already made). Should I push it to master or staging? It means
rebuilding all of our Haskell packages, which is a few hundered
packages.
Robert, do you know why the first patch doesn’t work? Should I just
omit it?
-- Tim