guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35790] [PATCH] scripts: lint: Separate the message warning text and


From: Ludovic Courtès
Subject: [bug#35790] [PATCH] scripts: lint: Separate the message warning text and data.
Date: Mon, 24 Jun 2019 10:36:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Hello,

Christopher Baines <address@hidden> skribis:

> +(define-syntax make-warning
> +  (syntax-rules (G_)
> +    ((_ package (G_ message) rest ...)
> +     (%make-warning package message rest ...))
> +    ((_ package message rest ...)
> +     (%make-warning package message rest ...))))

I think you can remove the second clause: that will ensure we never
forget to add a G_ around messages.

Otherwise LGTM!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]