guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#39480] [PATCH] gnu: Add zig compiler


From: Leo Famulari
Subject: [bug#39480] [PATCH] gnu: Add zig compiler
Date: Fri, 21 Feb 2020 13:07:50 -0500

On Fri, Feb 07, 2020 at 01:40:41PM +0100, Simon Nielsen wrote:
> Hi,
> 
> Adds the zig compiler as a new file in `gnu/packages/`

Thanks! Please add it to 'gnu/local.mk'.

> +(define-public zig-0.5.0

We can name it 'zig' until there are multiple versions in Guix.

> +     `(#:tests? #f

Why are the tests disabled? Is it because there is no test suite? Or
something else? Please add a brief code comment explaining it.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'fix-build
> +           (lambda _ (setenv "HOME" "/tmp") #t)))))

I guess that the build tries to access $HOME?

> +    (description
> +      "Programming languaged designed for robustness, optimality, and 
> clarity")

Can you try to make a more detailed description here? At least it should
be a complete sentence.

> +    (synopsis
> +      "Programming languaged designed for robustness, optimality, and 
> clarity")

Typo: languaged





reply via email to

[Prev in Thread] Current Thread [Next in Thread]