|
From: | raingloom |
Subject: | [bug#41803] [PATCH] Yggdrasil package and accompanying shepherd service (mesh network) |
Date: | Mon, 13 Jul 2020 16:23:30 +0200 |
On Sun, 12 Jul 2020 00:12:06 +0200 Julien Lepiller <julien@lepiller.eu> wrote: > > Hi, > > this is more of a quick review. > > First patch LGTM. > > You should split every package you add in the second patch in separate > patches. Also the commit message should say "new variable", no need to > say it's public. Done! > You left a comment about the license for go-github-com-gologme-log. > Have you contacted upstream to tell them about that, what was their > reaction? I think the fact that the readme says bsd implies the > intention is that it is free software, but better safe than sorry. Heck, I forgot to do that, but I have contacted them yesterday and they fixed it. > Otherwise, these packages lgtm. > > In the third patch again, the commit message should say "new > variable". You should not use the past tense either, so "Add it". > > Is the licenes lgpl3, or lgpl3+? Looks like (custom) lgpl3. The readme says so and I couldn't find anything to indicate that a later version would also be acceptable. > Not a go programmer, so I'm not reading the patch, but I'm trusting > you that it works :) > > For the fourth patch, I don't think you need to list new private > variables in the commit message, nor new dependencies. Only list > public variables, as "New variables". > > As you noted, could you add something about it to the manual? On it, but I've never used texinfo, so this might take a while. Gonna send it in a later mail. > In the system example, should Yggdrasil really be installed in the > system profile? If so, I think you can add a profile-service-type > extension to the service so the package is automatically available. > Then you don't need to specify the package in the os configuration, > and it ensures you install the same package (declared in the service > configuration) for the service and in the system. Technically it can be used without it, but yggdrasilctl is a useful tool. I added it with the profile-service-type extension and removed it from the packages field in the example. > Thanks for working on this! UwU
0001-gnu-go-golang-org-x-sys-update-to-05986578812163b266.patch
Description: Text Data
0002-gnu-Add-go-github-com-arceliar-phony.patch
Description: Text Data
0003-gnu-Add-go-github-com-cheggaaa-pb-at-version-3.0.4.patch
Description: Text Data
0004-gnu-Add-go-github-com-gologme-log-at-version-1.2.0.patch
Description: Text Data
0005-gnu-Add-go-github-com-hashicorp-go-syslog-at-version.patch
Description: Text Data
0006-gnu-Add-go-golang-zx2c4-com-wireguard-at-version-0.0.patch
Description: Text Data
0007-gnu-Add-go-github-com-kardianos-minwinsvc.patch
Description: Text Data
0008-gnu-Add-yggdrasil-at-version-0.3.14-plus-patch.patch
Description: Text Data
0009-gnu-services-Add-new-service-for-yggdrasil-network.patch
Description: Text Data
0010-gnu-system-add-example-with-yggdrasil.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |