[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53395] Fix pypi import for flake8-array-spacing
From: |
Vivien Kraus |
Subject: |
[bug#53395] Fix pypi import for flake8-array-spacing |
Date: |
Mon, 24 Jan 2022 23:07:46 +0100 |
User-agent: |
mu4e 1.6.10; emacs 27.2 |
Hi :)
Ludovic Courtès <ludo@gnu.org> writes:
> As a rule of thumb, warnings are one-line messages (not sentences)
> describing the problem. Here you could emit such a warning, followed by
> a call to ‘display-hint’, which accepts Texinfo markup.
display-hint seems to always add \n\n at the end of the message, is it
intended that way? Should I do one big display-hint instead of 3?
> Also, what about adding a unit test?
I added two by copying the "foo" example and pretending it’s named "Foo"
and "goo" respectively (fixing the package name in the json data), while
keeping release URLs as /foo-… so the importer should in the first case
recognize "Foo" in the URL and in the second case it should not
recognize "goo" in the URL so it should emit a warning. I didn’t test
the dash-to-underscore transformation, because it would require test
data with a package named "foo-something" but with release URIs
containing "foo_something". That data point does not exist currently in
the test module.
Vivien
0001-pypi-importer-Convert-to-_-in-pypi-urls-if-needed.patch
Description: Better handling of rogue pypi packages
signature.asc
Description: PGP signature