[bug#55751] [PATCH 1/8] gnu: openjdk9: Make build reproducible.

[Maxime Devos]

dannym@scratchpost.org schreef op wo 01-06-2022 om 15:00 [+0200]:
> +                             (let ((code (system* "unzip" "--" zip)))
> +                               (write code)
> +                               (newline)
> +                               (when (> (status:exit-val code) 1) ; 1 is 
> just a warning

What's the warning?  Maybe the warning can be addressed or we could ask
unzip to not do warnings and then this could simplified to (invoke
"unzip" ...).

> +                                 (raise (condition (&invoke-error
> +                                                    (program "unzip")
> +                                                    (arguments (list "--" 
> zip))
> +                                                    (exit-status 
> (status:exit-val code))
> +                                                    (term-signal 
> (status:term-sig code))
> +                                                    (stop-signal 
> (status:stop-sig code))))))))

This block could use a block explaining what it's for.
Likewise for the other undocumented block of code.

signature.asc
Description: This is a digitally signed message part