[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55774] [PATCH] gnu: quodlibet: Add dependencies for plugins to work
From: |
Liliana Marie Prikler |
Subject: |
[bug#55774] [PATCH] gnu: quodlibet: Add dependencies for plugins to work. |
Date: |
Fri, 03 Jun 2022 08:04:10 +0200 |
User-agent: |
Evolution 3.42.1 |
Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D:
> * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to
> work.
Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS...
> ---
> gnu/packages/music.scm | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 554d70f266..3751305b3c 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -47,6 +47,7 @@
> ;;; Copyright © 2022 Sughosha <sughosha@disroot.org>
> ;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
> ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> +;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -179,6 +180,7 @@ (define-module (gnu packages music)
> #:use-module (gnu packages vim) ;for 'xxd'
> #:use-module (gnu packages web)
> #:use-module (gnu packages webkit)
> + #:use-module (gnu packages wm)
> #:use-module (gnu packages wxwidgets)
> #:use-module (gnu packages xdisorg)
> #:use-module (gnu packages xml)
> @@ -6752,7 +6754,16 @@ (define-public quodlibet
> python-pygobject
> python-pytest
> python-sgmllib3k
> - python-toml))
> + python-toml
> + ;; optional but needed for multimedia keys not under
> Gnome
> + keybinder-3.0
> + ;; optional but needed for Undo/Redo
> + ;; support for multiline text fields
> + gtksourceview
> + ;; optional but needed for the auto library update plugin
> + python-pyinotify
> + ;; optional but needed for the Musicbrainz plugin
> + python-musicbrainzngs))
YMMV, but it's better for inputs to be sorted alphabetically. Use line
comments to demarcate specific features, e.g.
keybinder-3.0 ; keybindings outside of GNOME
gtksourceview ; undo, redo, multiline text fields
...
Don't forget the 79 character limit; when in doubt claim less features.
If possible, try to line up the comments.
Also, comments like "musicbrainz plugin needs python-musicbrainz" are
not as informative as you'd think and can probably be dropped :)
Cheers