[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55814] [PATCH v2] Updated python-flake8 and inputs to reenable buil
From: |
Maxime Devos |
Subject: |
[bug#55814] [PATCH v2] Updated python-flake8 and inputs to reenable build. |
Date: |
Mon, 06 Jun 2022 20:33:44 +0200 |
User-agent: |
Evolution 3.38.3-1 |
Christopher Rodriguez schreef op ma 06-06-2022 om 13:24 [-0400]:
> ---
>
> Maxime,
>
> Thanks for the feedback! Sorry for missing something so basic.
>
> I swapped both of the `if` statements with `when` statements, as they are more
> semantically appropriate here anyway.
>
> I also fixed a mistake I found in the lambda call (#:keys instead of #:key),
> and
> uploaded the current version of `python-flake8` (4.0.1) to the software
> heritage
> project. I'm waiting for the save to go through, but after that, the linter
> will
> return no errors.
>
> gnu/packages/python-xyz.scm | 54 ++++++++++++++++++-------------------
> 1 file changed, 26 insertions(+), 28 deletions(-)
Only a single independent change per patch, otherwise LGTM, haven't
looked at the source diff or build it though. On Software Heritage:
IIUC, saving something on SWH is not something you can do as individual
(except for git repos), rather, SWH asks a Guix server what sources are
used by packages. So effectively SWH will wait for the patch to be
applied before archiving it unless I'm misunderstanding things.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [bug#55814] [PATCH] Updated python-flake8 and inputs to reenable build., Christopher Rodriguez, 2022/06/05
- [bug#55814] [PATCH v3 1/8] Refreshed `python-pycodestyle` to version 2.8.0., Christopher Rodriguez, 2022/06/06
- [bug#55814] [PATCH v3 5/8] Added `python-pyflakes-2.3` as a variant package., Christopher Rodriguez, 2022/06/06
- [bug#55814] [PATCH v3 4/8] `python-flake8` now supports `#:tests?`, Christopher Rodriguez, 2022/06/06
- [bug#55814] [PATCH v3 3/8] `python-pycodestyle` now respects `#:tests?`, Christopher Rodriguez, 2022/06/06
- [bug#55814] [PATCH v3 7/8] Added `python-flake8-3.9` as a variant package., Christopher Rodriguez, 2022/06/06
- [bug#55814] [PATCH v3 2/8] Refreshed `python-flake8` to 4.0.1., Christopher Rodriguez, 2022/06/06
- [bug#55814] [PATCH v3 6/8] Added `python-pycodestyle-2.7` as a variant package., Christopher Rodriguez, 2022/06/06
- [bug#55814] [PATCH v3 8/8] Formatted Code with `guix style`., Christopher Rodriguez, 2022/06/06
- [bug#55814] Status of Rebuilds for Change, Christopher Rodriguez, 2022/06/06