[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#56041] [PATCH] gnu: Add vkmark.
From: |
( |
Subject: |
[bug#56041] [PATCH] gnu: Add vkmark. |
Date: |
Fri, 17 Jun 2022 20:10:15 +0100 |
Hi! :D This package seems good to me: passes all lints, builds, and
style looks okay.
On Fri Jun 17, 2022 at 4:24 PM BST, Tomasz Jeneralczyk wrote:
> +(define-public vkmark
> + (let ((commit "d872846e2e7c47010c11227eb713d00ccfdd35c6")
> + (revision "1"))
I think it's common to include an explanation of why tags aren't used :)
> + (file-name (git-file-name name version))
> + (uri (git-reference
> + (url "https://github.com/vkmark/vkmark")
> + (commit commit)))
Nitpick: file-name usually comes after uri in most of the packages I've
seen. Maybe run guix style, if you haven't already.
> + (native-inputs (list pkg-config cmake))
Why include cmake? It seems to compile without it :)
> + (synopsis "Benchmark for Vulkan")
Maybe expand this to "Extensible benchmarking suite for Vulkan" or
something? I'd say this synopsis is a bit too short.
- [bug#56041] [PATCH] gnu: Add vkmark., Tomasz Jeneralczyk, 2022/06/17
- [bug#56041] [PATCH] gnu: Add vkmark.,
( <=
- [bug#56041] Fwd: Re: [bug#56041] [PATCH] gnu: Add vkmark., (, 2022/06/18
- [bug#56041] Fwd: Re: [bug#56041] [PATCH] gnu: Add vkmark., (, 2022/06/18
- [bug#56041] [PATCH v2] gnu: Add vkmark., Tomasz Jeneralczyk, 2022/06/18
- [bug#56041] [PATCH v3] gnu: Add vkmark., Tomasz Jeneralczyk, 2022/06/19
- [bug#56041] [PATCH v4] gnu: Add vkmark., Tomasz Jeneralczyk, 2022/06/27