guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#56087] [PATCH] gnu: suckless: add farbfeld and propagate input to s


From: Maxime Devos
Subject: [bug#56087] [PATCH] gnu: suckless: add farbfeld and propagate input to sent
Date: Sun, 19 Jun 2022 15:17:54 +0200
User-agent: Evolution 3.38.3-1

Gabriel Wicki schreef op zo 19-06-2022 om 14:23 [+0200]:
> +       `(#:make-flags (list "PREFIX="
> +                            (string-append "DESTDIR=" %output)

Guix does not do staged installation (that's what DESTDIR is for!), so
don't set DESTDIR, instead set PREFIX to #$output instead of DESTDIR
(the difference matters when the compiled program embeds a reference to
its own installation location).  Also, G-exps, because %output isn't
documented IIRC whereas #$output is:

  (arguments
    (list #:make-flags
          #~(list (string-append "PREFIX=" #$output)
                  (string-append "CC=" #$(cc-for-target)))
          #:phases
          #~(modify-phases %standard-phases
              (delete 'configure)
              (delete 'check))))

Also, always add a comment about why tests are skipped (maybe someone
knows how to fix them or the bug they noticed!).

Greetings,
Maxime

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]