[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx.
From: |
Marius Bakke |
Subject: |
[bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx. |
Date: |
Thu, 23 Jun 2022 23:20:57 +0200 |
Nicolas Graves via Guix-patches via <guix-patches@gnu.org> skriver:
> ---
> gnu/build/chromium-extension.scm | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
This commit lacks a message describing the changed variable. The commit
title could also be more descriptive. ;-)
> diff --git a/gnu/build/chromium-extension.scm
> b/gnu/build/chromium-extension.scm
> index 8ca5251957..8d52153751 100644
> --- a/gnu/build/chromium-extension.scm
> +++ b/gnu/build/chromium-extension.scm
> @@ -19,10 +19,9 @@
> (define-module (gnu build chromium-extension)
> #:use-module (guix gexp)
> #:use-module (guix packages)
> - #:use-module (gnu packages chromium)
> #:use-module (gnu packages gnupg)
> #:use-module (gnu packages tls)
> - #:use-module (gnu packages xorg)
> + #:use-module (gnu packages node-xyz)
> #:use-module (guix build-system trivial)
> #:export (make-chromium-extension))
>
> @@ -69,24 +68,14 @@ (define version (package-version package))
> (string-append name "-" version ".crx")
> (with-imported-modules '((guix build utils))
> #~(begin
> - ;; This is not great. We pull Xorg and Chromium just to Zip and
> - ;; sign an extension. This should be implemented with something
> - ;; lighter. (TODO: where is the CRXv3 documentation..?)
Wohoo. :-)
> (use-modules (guix build utils))
> - (let ((chromium #$(file-append ungoogled-chromium "/bin/chromium"))
> - (xvfb #$(file-append xorg-server "/bin/Xvfb"))
> + (let ((crx3 #$(file-append node-crx3 "/bin/crx3"))
> (packdir (string-append (getcwd) "/extension")))
> (mkdir packdir)
> (copy-recursively (ungexp package package-output) packdir
> ;; Ensure consistent file modification times.
> #:keep-mtime? #t)
> - (system (string-append xvfb " :1 &"))
> - (setenv "DISPLAY" ":1")
> - (sleep 2) ;give Xorg some time to initialize...
> - (invoke chromium
> - "--user-data-dir=chromium-profile"
> - (string-append "--pack-extension=" packdir)
> - (string-append "--pack-extension-key=" #$signing-key))
> + (invoke crx3 "--keyPath" #$signing-key packdir)
LGTM! Feel free to add your copyright here too.
Can you send an updated series?
Thanks!
signature.asc
Description: PGP signature
- [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32., Nicolas Graves, 2022/06/14
- [bug#55959] [PATCH 4/9] gnu: Add node-resolve-protobuf-schema., Nicolas Graves, 2022/06/14
- [bug#55960] [PATCH 5/9] gnu: Add node-ieee754., Nicolas Graves, 2022/06/14
- [bug#55962] [PATCH 6/9] gnu: Add node-pbf., Nicolas Graves, 2022/06/14
- [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx., Nicolas Graves, 2022/06/14
- [bug#55964] [PATCH 2/9] gnu: Add node-yazl., Nicolas Graves, 2022/06/14
- [bug#55961] [PATCH 3/9] gnu: Add node-protocol-buffers-schema., Nicolas Graves, 2022/06/14
- [bug#55963] [PATCH 7/9] gnu: Add node-minimist., Nicolas Graves, 2022/06/14
- [bug#55965] [PATCH 8/9] gnu: Add node-crx3., Nicolas Graves, 2022/06/14