[bug#56213] [PATCH] gnu: Add maven-doxia-core

[Artyom V. Poptsov]

Hello Julien.

> Thanks for the patch!

Thanks for taking your time for reviewing my patch.  :-)

> Missing full stop at the end of the subject line.

Okay, added a full-stop.

FWIW, I'm usually following those rules when writing commit messages:
  https://cbea.ms/git-commit/#end

The rules explicitly say that a committer should not add a full-stop at
the end of the first line.

> This package actually has tests, could you enable them?

Unfortunately tests require JUnit5.  :-/

> The pom file references most of these as runtime dependencies, so we
> need to propagate them, so maven can find them.

> We also need to propagated the parent pom :)

Done.

However, 'guix lint' gave me the following warning:
--8<---------------cut here---------------start------------->8---
/home/avp/src/dist/guix/gnu/packages/maven.scm:3943:2: 
maven-doxia-core@2.0.0-M2: propagated inputs plexus-parent-pom@5.1 and 
plexus-parent-pom@4.0 collide
--8<---------------cut here---------------end--------------->8---

I don't know yet how to properly fix that; probably the issue is that I
made all the inputs propagated, but I don't see how to differentiate
them looking at the Doxia Core 'pom.xml'.

> This feels like a description of the whole Doxia project. Could you add
> maybe one sentence to explain how this package is related to the whole
> doxia project?

Done.

> Lastly, I would put this package just below maven-doxia-parent-pom, but
> that's mostly aesthetic :)

Done.

Please find the updated patch attached.

0001-gnu-Add-maven-doxia-core.patch
Description: Text Data

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

signature.asc
Description: PGP signature