[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60224] [PATCH 0/9] Improvements to our u-boot tooling
From: |
Ricardo Wurmus |
Subject: |
[bug#60224] [PATCH 0/9] Improvements to our u-boot tooling |
Date: |
Thu, 29 Dec 2022 20:18:57 +0100 |
User-agent: |
mu4e 1.8.13; emacs 28.2 |
Hi Maxim,
this looks reasonable to me. Some comments below.
A minor comment about the first patch: you still bind “outputs” in the
build phases, but since you’re using #$output anyway this value is never
used.
[PATCH 3/9] introduces a comment in the definition of “native-build?”,
which references %current-target-system, yet only %current-system is
used. Is this a mistake?
[PATCH 4/9] — This one appends arm-trusted-firmware-rk3399 instead of
prepending it. This differs from how it was done with the labeled
inputs. Does this have any consequences? Is the “firmware” label used
anywhere (such as downstream packages)? The same applies to patches
5/9, 7/9, and 8/9.
[PATCH 6/9] — The change from .bin to .elf confuses me. Is this due to the
fact that “target” is now actually set and the package build thus
behaves differently?
[PATCH 8/9] removes a reference to “firware”; this answers my question
to patch 4/9, but perhaps other such references remain?
--
Ricardo
- [bug#60224] [PATCH 0/9] Improvements to our u-boot tooling, Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 1/9] gnu: make-u-boot-package: Add a u-boot argument and use gexps., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 4/9] gnu: u-boot-pinebook-pro-rk3399: Remove input labels and use gexps., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 9/9] gnu: u-boot-puma-rk3399: Use make-u-boot-sunxi64-package., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 7/9] gnu: u-boot-rock64-rk3328: Fix build., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 3/9] gnu: make-uboot-package: Simplify build., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 8/9] gnu: u-boot-sifive-unmatched: Use gexps and remove inputs., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 2/9] gnu: make-u-boot-package: Install .imx files., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 5/9] gnu: u-boot-firefly-rk3399: Use gexps and fix cross-build., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 6/9] gnu: make-u-boot-sunxi64-package: Use gexps and adjust file name., Maxim Cournoyer, 2022/12/20
- [bug#60224] [PATCH 0/9] Improvements to our u-boot tooling,
Ricardo Wurmus <=