guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#64151] [PATCH] etc: Stop making sendemail behave strangely.


From: Maxim Cournoyer
Subject: [bug#64151] [PATCH] etc: Stop making sendemail behave strangely.
Date: Thu, 06 Jul 2023 11:49:25 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hi Ludo,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
>
>> Even with such a hypothetical --exclude-whomever switch added, I'd
>> argue that it is wrong to magically install this configuration without
>> any user interaction.
>
> Maybe that’s the main grief: that the new config was suddenly installed
> without fellow hackers realizing it (I, for one, wondered initially what
> magic made ‘git send-email’ Cc: all my friends :-)).
>
> Perhaps one way out is to suggest it in the manual without installing it
> automatically?  WDYT, Maxim?

I still think it has more value by being automatically installed, as
that way the pre-push hook that prevents unsigned commit is also
configured automatically, and new contributors would be likely to not
have it configured (by having missed it from the manual).

I see this similar to the .dir-locals.el file that automatically setups
(there's a prompt, but its design forces you into accepting it or being
repeatedly bothered ad aeternam).

If there are concrete issues with it, I think we should a) report them
and b) look into fixing them.

> (Independently of that, we’ll have to discuss patch review again.  We
> believed one problem was that potential reviewers wouldn’t notice
> patches in their area.  That’s arguably no longer the case, yet this
> hasn’t had any noticeable effect in terms of review activity.  How
> should we approach that?)

The teams are still nascent, and it's summer time.  I think we need to
give it some time and encourage more people to join or create new teams
and get familiar with the recently introduced/documented branch-based
updates :-).

-- 
Thanks,
Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]