[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#64711] [PATCH 40/43] gnu: pango: Support build for the Hurd.
From: |
Janneke Nieuwenhuizen |
Subject: |
[bug#64711] [PATCH 40/43] gnu: pango: Support build for the Hurd. |
Date: |
Tue, 18 Jul 2023 22:15:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Maxim Cournoyer writes:
Hi Maxim,
> Thanks for your efforts on this.
Sure. It's been fun, but a lot of work (world rebuilds) indeed. Things
will get a lot better once we have CI for these native Hurd builds.
> Janneke Nieuwenhuizen <janneke@gnu.org> writes:
>
>> * gnu/packages/gtk.scm (pango)[native-inputs]: Do not include
>> gobject-introspection when building for the Hurd.
>> ---
>> gnu/packages/gtk.scm | 14 ++++++++------
>> 1 file changed, 8 insertions(+), 6 deletions(-)
>>
>> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
>> index 853696c7f5..15dea2852b 100644
>> --- a/gnu/packages/gtk.scm
>> +++ b/gnu/packages/gtk.scm
>> @@ -401,12 +401,14 @@ (define-public pango
>> (list bash-minimal
>> zlib))
>> (native-inputs
>> - (list `(,glib "bin") ;glib-mkenums, etc.
>> - gobject-introspection ;g-ir-compiler, etc.
>> - help2man
>> - perl
>> - pkg-config
>> - python-wrapper))
>> + `((,glib "bin") ;glib-mkenums, etc.
>> + ,@(if (target-hurd?)
>> + '()
>> + (list gobject-introspection)) ;g-ir-compiler, etc.
>> + ,help2man
>> + ,perl
>> + ,pkg-config
>> + ,python-wrapper))
>
> Stylistically, I think it'd be better to use append (and 'if') here than
> quasiquotes (to avoid having to unquote all inputs).
Okay, I can change it to
(cons `(,glib "bin") ;glib-mkenums, etc.
(append (if (target-hurd?)
'()
(list gobject-introspection)) ;g-ir-compiler, etc.
(list help2man
perl
pkg-config
python-wrapper)))
> Otherwise it LGTM.
Thanks!
--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | AvatarĀ® https://AvatarAcademy.com
- [bug#64711] [PATCH 26/43] gnu: cairo: Support building for the Hurd., (continued)
- [bug#64711] [PATCH 29/43] gnu: tcsh: Skip substitution tests on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 38/43] gnu: ghostscript: Fix build for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 30/43] gnu: swig: Skip tests when building for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 42/43] gnu: po4a: Skip failing test on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 35/43] gnu: graphite2: Skip test on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 36/43] gnu: guile-git: Skip http proxy test on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 28/43] gnu: ruby-2.6: Skip test on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 40/43] gnu: pango: Support build for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
[bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd., Janneke Nieuwenhuizen, 2023/07/18