guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#68202] [PATCH 5/5] gnu: libsigsegv: Fix building for x86_64-linux-g


From: Mathieu Othacehe
Subject: [bug#68202] [PATCH 5/5] gnu: libsigsegv: Fix building for x86_64-linux-gnux32.
Date: Wed, 03 Jan 2024 09:43:32 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Hello Efraim,

> +      ;; On some architectures 'struct sigcontext' gets redefined from
> +      ;; %linux-libre-headers/include/asm/sigcontext.h
> +      ,@(cond ((target-mips64el?)
> +               `(#:phases (modify-phases %standard-phases
> +                            (add-before 'configure 'patch-mips-old-h
> +                              (lambda _
> +                                (substitute* "src/fault-linux-mips-old.h"
> +                                  (("#include <asm/sigcontext\\.h>") 
> "")))))))
> +              ((target-x32?)
> +               `(#:phases (modify-phases %standard-phases
> +                            (add-before 'configure 'patch-linux-x86_64-old-h
> +                              (lambda _
> +                                (substitute* "src/fault-linux-x86_64-old.h"
> +                                  (("#include <asm/sigcontext\\.h>") 
> "")))))))
> +              (else '()))))
>     (description
>      "GNU libsigsegv is a library to handle page faults, which occur when a
>  program tries to access an unavailable region of memory, in user mode.  By

#67859 is doing more or less the same thing, but for x86_64 as a
whole. Could you maybe replace `target-x32` by `target-x86`?

Maybe we should come up with a list of architectures that need that kind
of fix in libsigsegv and patch all the src/fault-linux-xxx-old-h?

The rest of the series seems fine to me.

Thanks,

Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]