[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#71460] Fixing commit message
From: |
Nicolas Goaziou |
Subject: |
[bug#71460] Fixing commit message |
Date: |
Mon, 10 Jun 2024 18:32:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello,
Thanos Apollo <public@thanosapollo.org> writes:
> Same patch, this time with a generated =Change-Id: ***=. Still learning
> how to properly format patches for Guix.
Thank you (for the package, too!).
> Subject: [PATCH] gnu: emacs-yeetube: Update to 2.1.6
>
> * gnu/packages/emacs-xyz.scm (emacs-yeetube): Update to 2.1.6.
You need to add that you removed wget dependency:
[arguments]<#:phases>: No longer replace (executable-find "wget") in
the code base.
[inputs]: Remove WGET.
> Change-Id: I6aee95029e829170a98d8fb7447bf0fd39ed6176
> ---
> gnu/packages/emacs-xyz.scm | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 2a943f5846..1d0519aa88 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -29074,10 +29074,10 @@ (define-public emacs-ytel-show
> (license license:gpl3+))))
>
> (define-public emacs-yeetube
> - (let ((commit "c74e4e77156297624d278a05bdd19c016a91ff9b")) ;version bump
> + (let ((commit "c9721a295f4fd30a44e94b3424151fa8a14d22ae"))
Why are you removing the comment? It is used to indicate that upstream
does not tag commits, but this commit matches the version bump anyway.
Otherwise, LGTM.
Regards,
--
Nicolas Goaziou