guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#70400] [PATCH 3/7] gnu: python-lsp-jsonrpc: Update to 1.1.2.


From: Nicolas Graves
Subject: [bug#70400] [PATCH 3/7] gnu: python-lsp-jsonrpc: Update to 1.1.2.
Date: Sun, 16 Jun 2024 00:53:15 +0200

On 2024-04-15 19:45, Jonathan Pieper via Guix-patches via wrote:

> * gnu/packages/python-xyz.scm (python-lsp-jsonrpc): Update to 1.1.2.
>   [build-system]: Change to pyproject-build-system.
>   [arguments]{set-version}: Set version explicitly to pass sanity-check.

I rather use "<#:phases>: Add phase 'set-version to pass sanity-check"
but I'm not sure that's a stabilized standard.

>   [native-inputs]: Add python-pytest-cov.
>
> Change-Id: I3ffaf75ced25bd95d8f7486294364fb52b86b08b
> ---
>  gnu/packages/python-xyz.scm | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 27107c3d8f..e0817e4c9d 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -7559,19 +7559,24 @@ (define-public python-feedgenerator
>  (define-public python-lsp-jsonrpc
>    (package
>      (name "python-lsp-jsonrpc")
> -    (version "1.0.0")
> +    (version "1.1.2")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "python-lsp-jsonrpc" version))
>         (sha256
> -        (base32
> -         "1gb0fsamxndhplx25v8m0b3k7aknzy454fpa0qsqsqnv6c3igv3v"))))
> -    (build-system python-build-system)
> -    (native-inputs
> -     (list python-mock python-pytest))
> -    (propagated-inputs
> -     (list python-ujson))
> +        (base32 "04n95h0cqnsrdyh1gv0abh2i5ynyrq2wfqpppx9djp7mxr9y9226"))))
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'set-version
> +                    (lambda _
> +                      (substitute* "pyproject.toml"
> +                        (("dynamic = \\[\"version\"\\]")
> +                         (string-append "version = \""
> +                                        ,version "\""))))))))
> +    (build-system pyproject-build-system)

nitpick: arguments is clearer after build-system field.
Otherwise LGTM.
> +    (native-inputs (list python-mock python-pytest python-pytest-cov))
> +    (propagated-inputs (list python-ujson))
>      (home-page "https://github.com/python-lsp/python-lsp-jsonrpc";)
>      (synopsis "JSON RPC 2.0 server library")
>      (description

-- 
Best regards,
Nicolas Graves





reply via email to

[Prev in Thread] Current Thread [Next in Thread]