[bug#71319] [PATCH v2 2/3] gnu: emacs-ddskk: Improve package style.

[Nicolas Goaziou]

Hello,

gemmaro <gemmaro.dev@gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ddskk)[arguments]: Use newer
> package style.

Thanks. Some comments follow.

> +       (list #:modules '((guix build gnu-build-system)
> +                         (guix build utils)
> +                         (guix build emacs-utils))
> +             #:imported-modules `(,@%gnu-build-system-modules
> +                                  (guix build emacs-utils))
> +             #:test-target "test"
> +             #:phases
> +             #~(modify-phases %standard-phases
> +                 (replace 'configure
> +                   (lambda* (#:key outputs #:allow-other-keys)

Use (lambda _ ...) here.

> +                     (make-file-writable "SKK-MK")

I don't think this line is necessary. Could you double-check?

> +                     (emacs-substitute-variables "SKK-MK"
> +                       ("PREFIX" (assoc-ref outputs "out"))

(assoc-ref outputs "out") -> #$output

> +                       ("LISPDIR" '(expand-file-name 
> "/share/emacs/site-lisp" PREFIX))
> +                       ("SKK_PREFIX" "")
> +                       ("SKK_INFODIR" '(expand-file-name "info" PREFIX)))
> +                     (for-each make-file-writable (find-files "./doc"))
> +                     #t))

Could you remove this trailing #T, too?

Regards,
-- 
Nicolas Goaziou