[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#72062] [PATCH 3/4] gnu: Add openmpi-5.
From: |
Ludovic Courtès |
Subject: |
[bug#72062] [PATCH 3/4] gnu: Add openmpi-5. |
Date: |
Fri, 12 Jul 2024 10:40:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello!
Romain GARBAGE <romain.garbage@inria.fr> skribis:
> * gnu/packages/mpi.scm (openmpi-5): New variable.
>
> Change-Id: I048692b2e928077c9cfa9fb8076ceb356251e1db
[...]
> +(define-public openmpi-5
> + (package/inherit openmpi
I think it’s a case where (package (inherit openmpi) …) is more
appropriate: ‘package/inherit’ would cause the ‘replacement’ of
‘openmpi’ to be inherited, which is probably not a good idea since it’s
a different version.
> + (substitute-keyword-arguments (package-arguments openmpi)
> + ((#:configure-flags flags)
> + #~(append (list "--enable-prte-prefix-by-default" ;replaces
> --enable-mpirun-prefix-by-default
> + ;; Enable support for the 'Process Management
> + ;; Interface for Exascale' (PMIx) used e.g. by
> + ;; Slurm for the management communication and
> + ;; coordination of MPI processes.
> + (string-append "--with-pmix=" #$(this-package-input
> "openpmix"))
> + (string-append "--with-prrte=" #$(this-package-input
> "prrte"))
> +
> + ;; Since 5.x, Infiniband support is provided by ucx.
> + (string-append "--with-ucx=" #$(this-package-input
> "ucx")))
> + (filter (lambda (e)
> + (and (not (string-contains e "pmi")) ;; Since
> 5.x, OpenMPI doesn't support PMI/PMI-2
> + ;; Deprecated since 5.x.
> + (not (string-contains e
> "enable-mpirun-prefix-by-default"))
> + ;; Infiniband support is deprecated and
> superseded by ucx
> + ;; See
> https://docs.open-mpi.org/en/main/release-notes/networks.html#miscellaneous-network-notes
> + (not (string-contains e "openib"))))
> + #$flags)))
How about listing all the configure flags explicitly rather than
relative to those of 4.x? I feel like this would be clearer and that
there’s little to be gained by factorizing anyway.
Thanks,
Ludo’.
- [bug#72062] [PATCH 0/4] Add OpenMPI 5.x, Romain GARBAGE, 2024/07/11
- [bug#72062] [PATCH 1/4] gnu: Add openpmix., Romain GARBAGE, 2024/07/11
- [bug#72062] [PATCH 0/4] Add OpenMPI 5.x, Romain GARBAGE, 2024/07/12
- [bug#72062] [PATCH 0/4] Add OpenMPI 5.x, Ludovic Courtès, 2024/07/12
- [bug#72062] [PATCH v2 0/5] Add OpenMPI 5.x., Romain GARBAGE, 2024/07/12
- [bug#72062] [PATCH v2 1/5] gnu: Add openpmix., Romain GARBAGE, 2024/07/12
- [bug#72062] [PATCH v2 3/5] gnu: slurm: Add PMIx support., Romain GARBAGE, 2024/07/12
- [bug#72062] [PATCH v2 5/5] gnu: openmpi: Set default version to 4.x., Romain GARBAGE, 2024/07/12
- [bug#72062] [PATCH v2 4/5] gnu: Add openmpi-5., Romain GARBAGE, 2024/07/12
- [bug#72062] [PATCH v2 2/5] gnu: Add prrte., Romain GARBAGE, 2024/07/12