[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#71697] [PATCH v4 1/2] scripts: lint: Add 'dry-run' option.
From: |
Ludovic Courtès |
Subject: |
[bug#71697] [PATCH v4 1/2] scripts: lint: Add 'dry-run' option. |
Date: |
Thu, 18 Jul 2024 11:19:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi,
Simon Tournier <zimon.toutoune@gmail.com> skribis:
> + (fold-packages (lambda (p r)
> + (show-package-checkers p checkers)
> + (when (not (assoc-ref opts 'dry-run?))
> + (run-checkers p checkers
> + #:store store))) '()))
I’d call ‘show-package-checkers’ only for dry runs (like it would print
“the following checkers would run: …”). That said, I find ‘--dry-run’
in this case not so useful because it would just print the same thing on
and on for each and every package.
Also, s/when not/unless/.
Ludo’.