guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0


From: Simon Tournier
Subject: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0
Date: Thu, 5 Sep 2024 17:34:47 +0200

Hi,

Since changes to the package Git imply large rebuilds, this series integrates
submission #72413.

Change since v2: Restore the ’origin’ of git-manpages under native-inputs.

Commit f288604428e9c8f096ec9e0eccf207e079806271 moved the origin inside the 
phase.

--8<---------------cut here---------------start------------->8---
+          (add-after 'split 'install-man-pages
+            (lambda _
+              (let ((man (string-append #$output "/share/man")))
+                (mkdir-p man)
+                (with-directory-excursion man
+                  (invoke
+                   "tar" "xvf"
+                   #$(origin
+                       (method url-fetch)
+                       (uri (string-append
+                             "mirror://kernel.org/software/scm/git/"
+                             "git-manpages-" version ".tar.xz"))
+                       (sha256
+                        (base32
+                         
"0xsqakgy0s60zpa13ilj6zj420kdh8pf4v3nrp1nziwj8ja4qymw"))))))))
--8<---------------cut here---------------end--------------->8---

And this appears to me a bad idea, because 1. it makes harder to know what are
the inputs and more importantly 2. it is hidden from procedure
’package-direct-sources’, which means it will not be archived.

Cheers,
simon


1:  https://issues.guix.gnu.org/72413

Ashish SHUKLA (1):
  gnu: git: Update to 2.46.0

Simon Tournier (2):
  gnu: git: Fix perl search-paths of wrapped programs.
  gnu: git: Move git-manpages origin from phases to native-inputs.

 gnu/packages/version-control.scm | 77 +++++++++++++++++++-------------
 1 file changed, 47 insertions(+), 30 deletions(-)


base-commit: 7d2ced8d6d9c38327592d312376d59a8c37fc160
-- 
2.45.2






reply via email to

[Prev in Thread] Current Thread [Next in Thread]