[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#74686: [PATCH] daemon: Fix linking gcrypt when --as-needed linker ar
From: |
Ludovic Courtès |
Subject: |
bug#74686: [PATCH] daemon: Fix linking gcrypt when --as-needed linker arg is used |
Date: |
Mon, 09 Dec 2024 23:14:15 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi,
Doğan Çeçen <sepeth@fastmail.com> skribis:
> As it is mentioned in autoconf manual that library names should be
> specified in LIBS, not LDFLAGS. See:
>
> https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/html_node/Preset-Output-Variables.html#index-LDFLAGS-2
>
> This change also brings back the save_* vars trick that was there
> before. I missed in my earlier change that nix/local.mk was referring
> LIBGCRYPT_* vars directly.
>
> And, instead of CXXFLAGS, CPPFLAGS is used since the latter is probably
> more correct as this is used for include dirs, therefore using
> preprocessor flags.
>
> Tested with ./configure LDFLAGS="-Wl,--as-needed" --with-libgcrypt-prefix=...
> combinations.
>
> Change-Id: Iadb10e1994c9a78e2927847af2cfe5e096fbb2a8
Applied with a ChangeLog-style commit log, thanks.
(I was surprised by some of the changes in the first patch; thanks for
following up!)
Ludo’.