[bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition.

[Ian Eure]

Hi Nicolar, Rostislav,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:
>
> > >     (arguments
> > >      (list
> > >       #:tests? #f ; requires an attached terminal
> > >       ))
> > >     (native-inputs
> > >      (list emacs-ert-runner))
> > >
> > > "#:tests? #f" with a reason brings some valuable 
> > > information. I simply suggest
> > > to keep that line.
> >
> > If the default for #:tests? ever flips to #t, an explicit 
> > #:tests? #f
> > if overlooked, would prevent tests from running, even though 
> > everyone
> > might assume they are.

The change to run tests for Emacs packages is implemented in 
#76686 and likely to merge soon, so this argument is moot.

To move forward on this:

- Please do what’s needed to make the tests run.  Guix has a 
 strong preference to run tests for all packages.
- Alternately, if there is a compelling rationale why the tests 
 cannot/should not run for this package (examples: they take a 
 very long time to run; they’re broken or flaky upstream; it’s 
 unduly burdensome to make the package run them), then please 
 explain why, and explicitly set `(#:tests? #:f)'.
- Resend a v2 patch series with `git send-email'.
- Trim the 831(!) "prerequisite-patch-id" lines.
- Please make sure all patches in the series make it to a single 
 bug.  This didn’t happen, so the work is split between #74135 
 and #74136.  See `(guix) Sending a Patch Serues'[1].  You’re 
 welcome to close #74136 and send both patches here, or close 
 both open bugs and open a new one.

Thanks,
 -- Ian

[1]: 
https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html