Re: [PATCH] gwl/ui: Check for log-events configuration

[Ricardo Wurmus]

Olivier Dion <olivier.dion@polymtl.ca> writes:

> On Sat, 04 Jun 2022, Ricardo Wurmus <rekado@elephly.net> wrote:
>> Olivier Dion <olivier.dion@polymtl.ca> writes:
>>
>>> Some GWL sub-commands such as `graph' do not accept a log event 
>>> configuration.
>>> This results in returning `#f' from `(%config 'log-events)'
>>
>> I don’t understand how this leads to a problem.  Do any of the features
>> of “graph” use “log-event”?
>
> Yes.  `load-workflow' -> `load-workflow*' -> `load*' -> `log-event 'info
> "Loading workflow file"'.

I see.

Does it make sense to support the --log-events option on “graph”?  Or
should we just work around it in the log-event procedure?

>> Generally, I’d prefer to give “log-events” a better default.  I can’t
>> imagine a situation where #F (rather than the empty list) would be
>> appropriate.
>
> The empty list would be a more sane choice I agree. I'll send a v2 with
> this change.  Also, the `print?` predicate could be memoize with `mlambda'?

Yes, “print?” could me memoized.

-- 
Ricardo