Possible bug in cfenvd.c

[Rune Mossige]

Trying cfengine-2.0.a23 on a Solaris2.6 box revealed a possible bug.

After cfenvd had been running for a while (an hour or so), we noticed
that it was using a huge amount of memory.

We then forced a core dump, and ran it via gdb, and this showed that it
stopped in line 767:
767        for (sp = ip->name; sp != '\0'; sp++)
                              ^^^

This, to us, did not look correct. We supposed that this should be
using 'for (sp = ip->name; *sp != '\0'; sp++)' instead. We made this
change, re-compiled cfenvd.c, and it have now been running for several
hours without consuming any abnormal cpu time.

A diff show:

diff cfenvd.c cfenvd.c-DIST
767c767
<    for (sp = ip->name; *sp != '\0'; sp++)
---
>    for (sp = ip->name; sp != '\0'; sp++)

If this really is a bug, we would like to see this fixed in the next
beta release.

-- 
-------------------------------------------------------------------
           (-: Hiroshima 45, Chernobyl 86, Windows 95 :-)
Our ultimate goal is to make overloaded systems appear to be idle.
High performance, High reliability, Low cost -------- Pick any two.
-------------------------------------------------------------------
Rune  Mossige,  Systems  Support  Engineer,  WesternGeco, Stavanger
Tel: (+47)51946869                             Mobile:(+47)90871024