[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Extra files in build container
From: |
Ludovic Courtès |
Subject: |
Re: Extra files in build container |
Date: |
Mon, 19 Jun 2017 13:26:37 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hi Gregor,
Gregor Giesen <address@hidden> skribis:
> On Fri, Jun 16, 2017 at 09:58:55AM +0200, Ludovic Courtès wrote:
>> In cases like the one you describe, we usually end up modifying tests to
>> use the numerical values for services and protocols rather than their
>> names.
> Unfortunately, this turns out to be quite cumbersome since in my case
> (unittests for unbound) there is a lot of test data to be modified and
> in many cases not only plain text but also encrypted records (DNSSEC
> tests). On the other hand the values to be looked up are mostly “udp”
> and “tcp” in /etc/protocols and “domain” in /etc/services, so I decided
> that using a preload library for these few glibc calls just in case of
> the unittest should do the trick rather than no checks at all.
I think it would be easier to just use ‘substitute*’ to replace all the
occurrences of “tcp”, etc., wouldn’t it?
> However, it is an ugly hack and bloats the package definition.
I agree, but it’s hard to improve on it without compromising
reproducibility.
Thanks,
Ludo’.