[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Behaviour change when closing laptop lid: it no longer suspends
From: |
Pierre Neidhardt |
Subject: |
Re: Behaviour change when closing laptop lid: it no longer suspends |
Date: |
Mon, 18 Jan 2021 18:37:28 +0100 |
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hi Tobias,
>
> Tobias Geerinckx-Rice <me@tobias.gr> writes:
>
>> However, here our wrapping is wrong. Thanks for making me look into
>> it.
>>
>> From upstream's change log:
>>
>> The action that elogind takes when the lid is closed and the
>> machine is connected to external power can now be configured
>> using HandleLidSwitchExternalPower= in logind.conf. Previously,
>> this action was determined by HandleLidSwitch=, and, for
>> backwards compatibility, is still is, if
>> HandleLidSwitchExternalPower= is not explicitly set.
>>
>> Whilst we:
>>
>> ("HandleLidSwitchExternalPower"
>> (handle-action elogind-handle-lid-switch-external-power))
>>
>> always ‘explicitly set’ HandleLidSwitchExternalPower, by default to
>> ‘ignore’, breaking that intention.
>>
>> elogind-handle-lid-switch-external-power should not emit a directive
>> if unset. In fact, all directives and all services should do that by
>> default, *not* hard-code upstream's default at an arbitrary point in
>> time.
>
> Oh, nice find! So we have something to fix.
Thanks for digging this out, Tobias!
Anyone in the mood to work on a patch? :)
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP signature