[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Packaging Proton Bridge: Progress Report #1
From: |
Ian Eure |
Subject: |
Re: Packaging Proton Bridge: Progress Report #1 |
Date: |
Mon, 09 Dec 2024 16:38:20 +0000 |
Hi Marek,
On Mon, Dec 9, 2024, at 4:24 PM, Marek Paśnikowski wrote:
> I managed to break through version incompatibilites thanks to discovery of
> the
> guix:build-system:go:go-version->git-ref function, which allowed me to use
> the
> specifications in go.mod files directly.
>
> I am currently blocked on what seems to be an actual upstream coding bug, for
> which I filed a report:
> https://github.com/ProtonMail/proton-bridge/issues/511
>
> It boils down to an undefined variable reference, which used to be defined
> two
> years ago.
>
> Build error:
> src/github.com/ProtonMail/proton-bridge/v3/internal/frontend/cli/system.go:
> 48:43: undefined: bridge.Credits
>
> Commit reference:
> https://github.com/ProtonMail/proton-bridge/commit/
> 77cd2955f1413c96a1d987d0d7f9d8ecf6a8ad49
>
> The removed code snippet in file internal/bridge/credits.go :
> package bridge
> const Credits = "string of go module paths"
>
This isn't an upstream bug, it's an error in your package. As the
"(generated)" comment in .gitignore in your liked commit implies, this file is
now codegenned as part of the build:
https://github.com/ProtonMail/proton-bridge/blob/4f4a2c3fd8f7304a9b3ff81d3f42828b95296b7f/Makefile#L351-L353
Since you're not running the command that creates the file, the build fails.
-- Ian