Re: [PATCH 2/4] Make _asn1_ordering_* return error values and check them.

[Kurt Roeckx]

On Thu, Apr 24, 2014 at 10:32:15PM +0200, Kurt Roeckx wrote:
> On Thu, Apr 24, 2014 at 10:12:56PM +0200, Nikos Mavrogiannopoulos wrote:
> > On Thu, Apr 24, 2014 at 6:39 PM, Kurt Roeckx <address@hidden> wrote:
> > > I still see:
> > > PASS: certificate_set_x509_crl
> > >
> > > Did you also apply the first patch?  That fixes an existing bug
> > > that causes errors for me too in the libtasn1 test suite.
> > 
> > Could it be that it isn't linked to the new libtasn1, or using the
> > included? Yes, I had both 2 patches applied. I'll check again once
> > back home.
> 
> I assumed I was using the minitasn1 version, but it seems it's
> linked to libtasn1 anyway.
> 
> When I set LD_LIBRARY_PATH to point to the new one, I actually end
> up with:
> # TOTAL: 83
> # PASS:  55
> # SKIP:  2
> # XFAIL: 0
> # FAIL:  26
> # XPASS: 0
> # ERROR: 0
> 
> Looks like lots of fun.

At first sight, it looks like a problem in the
_asn1_ordering_set_of() function.  I think it now gets called
properly but I think it screws something up.

The logic in it looks weird, and I don't know enough about
BER yet to know what it should do in the first place.  I'll
try to take a look at this soon.


Kurt