Re: [PATCH 2/4] Make _asn1_ordering_* return error values and check them.

[Kurt Roeckx]

On Tue, Apr 22, 2014 at 01:06:26AM +0200, Nikos Mavrogiannopoulos wrote:
> On Sun, 2014-04-20 at 16:50 +0200, Kurt Roeckx wrote:
> > diff --git a/lib/coding.c b/lib/coding.c
> > index 705f8b1..38824b3 100644
> > --- a/lib/coding.c
> > +++ b/lib/coding.c
> 
> Thank you Kurt for the patch set. This particular patch looks reasonable
> but it makes the gnutls test suite fail. A simple example
> is ./certificate_set_x509_crl which decodes a CRL and re-encodes it (and
> that's the point it fails). I have not yet investigated the reason it
> fails. Most probably we'll need this test in libtasn1 as well.

I still see:
PASS: certificate_set_x509_crl

Did you also apply the first patch?  That fixes an existing bug
that causes errors for me too in the libtasn1 test suite.


Kurt