[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Copies of argv elements in asn1Decoding
From: |
Nikos Mavrogiannopoulos |
Subject: |
Re: Copies of argv elements in asn1Decoding |
Date: |
Wed, 25 May 2016 17:15:49 +0200 |
On Sun, May 22, 2016 at 9:55 PM, Pascal Cuoq <address@hidden> wrote:
> Note 1: one may consider strdup instead of strlen + malloc + strcpy, but
> strdup is not in standard C despite being in SVr4, 4.3BSD, and POSIX.1-2001.
> Presumably this is why it is not used. I still think that inputFileAsnName =
> argv[optind]; … (and getting rid of all the free calls for these variables)
> would be simpler.
Hi Pascal,
I'll encourage you to clean up this tool and provide any patches you
think are necessary. Just make sure that the changed code is tested
and doesn't regress. I don't think the reason of malloc() + strcpy()
is because of POSIX or so, it was simply quickly written.
regards,
Nikos