Re: make381beta1

[Paul D. Smith]

%% "Markus Mauhart" <address@hidden> writes:

  mm> *) main.c, function log_working_directory(), is missing a "fflush(stdout)"

OK, I fixed this.

  mm> *) Assume we have the cmdline "make -f mkfile a=aa b=bb c=cc", and
  mm> file mkfile contains a rule with the cmd "$(MAKE) -f mkfile c=CC
  mm> d=DD e=EE".  Then inside the executed sub-make, "$(MAKEOVERRIDES)"
  mm> evaluates to ...  "e=EE d=DD c=CC a=aa b=bb c=CC".  So the strange
  mm> and redundant thing is that the variable named 'c' comes twice,

OK, I fixed this.

  mm> *) w32/sub_proc/sub_proc.c fails to compile under
  mm> msys+mingw-gcc342, cause function "process_file_io" is used before
  mm> beeing declared.

OK, I fixed this.

  mm> *) dir.c contains ...
  mm> # if __MINGW32_VERSION_MAJOR < 3 || (__MINGW32_VERSION_MAJOR == 3 && \
  mm>          __MINGW32_VERSION_MINOR == 0)

  mm> .. but the correct names are __MINGW32_MAJOR_VERSION and
  mm> __MINGW32_MINOR_VERSION,

OK, I fixed this.

  mm> *) I think there is a bug w.r.t. target specific variables, at least my
  mm> code doesnt work.

  mm> If this is really a bug my guess is that the definition of the
  mm> target-specific variable uses the "global variable database" instead
  mm> of the "current DB" (which is used for the rule's targets and for
  mm> its prerequisites).

Hmm.  This is a tricky one.  I think it is a bug; can you submit it to
the make bug tracker in Savannah so we don't lose track of it?

-- 
-------------------------------------------------------------------------------
 Paul D. Smith <address@hidden>          Find some GNU make tips at:
 http://www.gnu.org                      http://make.paulandlesley.org
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist