Re: gsvd test error - diff

[Markus Mützel]

I agree. The tests should not be coupled like they currently are. These side 
effects made it pretty difficult to understand what the actual issue is.

In the meantime a bug report about this issue has been opened:
https://savannah.gnu.org/bugs/?65296

Maybe, we should continue there.

Markus

Am 13. Februar 2024 um 05:22 Uhr schrieb "Thomas D. Dean":
> On 2/12/24 04:45, Markus Mützel wrote:
> > Your proposed change doesn't look correct to me.
> 
> Correct.  My error - sorry.
> 
> In gsvd.cc:
> I inserted assert (size (A), [3, 5]) after line 333 and at the start of 
> the next test at line 340.
> 
> The shape of A is 3x5 at line 333.
> https://hg.savannah.gnu.org/hgweb/octave/file/19973af3ac42/libinterp/corefcn/gsvd.cc#l334
> This is after the call to gsvd (A, B).
> The display of shared variables in this test shows A to have shape 5x3.
> 
> The shape of A is 5x3 at line 340.
> https://hg.savannah.gnu.org/hgweb/octave/file/19973af3ac42/libinterp/corefcn/gsvd.cc#l340
> 
> Tom Dean
>