[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Help-smalltalk] Re: Question regarding DatagramSocket...
From: |
Holger Hans Peter Freyther |
Subject: |
[Help-smalltalk] Re: Question regarding DatagramSocket... |
Date: |
Sat, 12 Jun 2010 12:12:34 +0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b1 Thunderbird/3.0.4 |
On 06/11/2010 11:33 PM, Paolo Bonzini wrote:
> Just name it "size" please. There is no <comment: ''> pragma in
> methods. Finally, please put a single ^ outside the if blocks.
So no return from within the if? What is the reasoning? What would be
preferred, assign to a local variable and then return, or put the return
before the object ifNil check?
>
> This should go to a (very high) superclass as you suspected.
I picked the AbstractSocket class... maybe we should even move it into
SocketAddr?
I have three patches attached to carry out these changes. Looking for
comments.
0001-UDP-Make-it-possible-to-find-out-how-many-bytes-were.patch
Description: Text Data
0002-2010-06-12-Holger-Hans-Peter-Freyther-zecke-selfish..patch
Description: Text Data
0003-2010-06-12-Holger-Hans-Peter-Freyther-zecke-selfish..patch
Description: Text Data
- [Help-smalltalk] Question regarding DatagramSocket..., Holger Hans Peter Freyther, 2010/06/11
- Re: [Help-smalltalk] Question regarding DatagramSocket..., Paolo Bonzini, 2010/06/11
- Re: [Help-smalltalk] Question regarding DatagramSocket..., Holger Hans Peter Freyther, 2010/06/11
- [Help-smalltalk] Re: Question regarding DatagramSocket..., Paolo Bonzini, 2010/06/11
- [Help-smalltalk] Re: Question regarding DatagramSocket...,
Holger Hans Peter Freyther <=
- Re: [Help-smalltalk] Re: Question regarding DatagramSocket..., Paolo Bonzini, 2010/06/12
- Re: [Help-smalltalk] Re: Question regarding DatagramSocket..., Holger Hans Peter Freyther, 2010/06/16
- Re: [Help-smalltalk] Re: Question regarding DatagramSocket..., Paolo Bonzini, 2010/06/16
- Re: [Help-smalltalk] Re: Question regarding DatagramSocket..., Stefan Schmiedl, 2010/06/16