[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] smalltalk-mode typo
From: |
Paolo Bonzini |
Subject: |
Re: [Help-smalltalk] smalltalk-mode typo |
Date: |
Tue, 11 Jan 2011 08:48:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6 |
On 01/10/2011 09:32 PM, Denis Washington wrote:
Let me know if that fix the issue.
It does. So it's no typo after all... thanks for pointing this out.
Yeah, sorry for applying the patch too fast. I'm changing instead
smalltalk-mode.el to use save-excursion. Since the original-point
keyword argument is only used to restore it on exit, and it always does
this, you can replace
(if ...
(progn (goto-char original-point) (point))
(prog1 (point) (goto-char original-point)))
with
(or (save-excursion
(if ...
nil
(point)))
(point)
(This seems more complicated, but the "if" is inside its own function so
it's not bad).
Can anybody suggest a shortcut for
smalltalk-goto-{previous,next}-keyword? It seems relatively useful even
in day-to-day use.
Paolo
0001-change-defun-to-defun.patch
Description: Text document