Building CVS on Windows is broken...again

[Dennis Jones]

The latest version of CVS (1.11.13) fails to build on Windows...again.
Building from the command line using NMAKE, results in the following errors:

.\src\subr.c(939) : error C2065: 'F_GETFL' : undeclared identifier
.\src\subr.c(942) : error C2065: 'F_SETFL' : undeclared identifier
.\src\subr.c(942) : error C2065: 'O_NONBLOCK' : undeclared identifier

Apparently, a new function called, set_nonblock_fd(), has been added to this
version of CVS, but was never tested for its buildability on Windows.  The
new function calls fcntl(), which is not available to Windows NT.  I even
found the following comment in the windows-NT/run.c file:

/*
   You can apparently specify _O_NOINHERIT when you open a file, but there's
   apparently no fcntl function, so you can't change that bit on an existing
   file descriptor.
*/

So somebody obviously knew that fcntl() wasn't available to Windows NT, but
whoever wrote set_nonblock_fd() either didn't know it, or forgot.

- Dennis


---
[This E-mail Scanned for viruses by Onlinemac.com]