[Koha-devel] Bug fix

[Andrés Tarallo]

Today we've been hunting a strange BUG. While doing that we updated the 
C4 modules from the latest one in the CVS.  Our test instlation is 2.1.2 
version of Koha.

Attached below you'll find a patch with some bugfixes for the Auth.pm 
module. Maybe calling them bugs is not a good idea, but we took away 
some annoying messages from the logs.

Any feedback is welcome


Andres

--- Auth.pm.orig        2004-11-12 11:48:22.197044584 -0300
+++ Auth.pm     2004-11-12 12:10:48.605359408 -0300
@@ -365,6 +365,13 @@
                        return 1,$userid;
                }
        }
+# 12-11-2004 A. Tarallo (address@hidden) This is a quick hack to get rid of
+# a complain that $userid and $password aren't initialized.
+#
+#------------------------------------------------------------------------------
+       $userid=$userid.'';
+       $password=$password.'';
+#-------------------------------------------------------------------------------
        if ($userid eq C4::Context->config('user') && $password eq 
C4::Context->config('pass')) {
                # Koha superuser account
                return 2;
@@ -387,9 +394,16 @@
     $sth=$dbh->prepare("SELECT bit, flag, defaulton FROM userflags");
     $sth->execute;
     while (my ($bit, $flag, $defaulton) = $sth->fetchrow) {
-       if (($flags & (2**$bit)) || $defaulton) {
-           $userflags->{$flag}=1;
-       }
+# 12/11/2004 A. Tarallo (address@hidden) In the error log of Apache there's
+# a complain that $flags isn't initialized. This is a Quick hack to get rid of
+# this error.
+#------------------------------------------------------------------------------
+           $flags+=0;
+           $bit+=0;
+#------------------------------------------------------------------------------
+           if (($flags & (2**$bit)) || $defaulton) {
+               $userflags->{$flag}=1;
+           }
     }
     return $userflags;
 }