[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: configurable link base patch
From: |
Marcus Brinkmann |
Subject: |
Re: configurable link base patch |
Date: |
Mon, 6 Oct 2003 14:03:06 +0200 |
User-agent: |
Mutt/1.5.4i |
Hi,
I spotted a couple of more things.
On Sun, Oct 05, 2003 at 11:39:00PM +0200, Maurizio Boriani wrote:
> +laden_LDFLAGS = -u_start -e_start -N -nostdlib address@hidden@
There is no reason not to use full words, like LADEN_LINK_ADDRESS,
or LADEN_LOAD_ADDRESS. In fact, I prefer LOAD_ADDRESS over LINK_ADDRESS.
> AC_ARG_WITH(laden-ld-addr,
> [ --with-laden-ld-addr laden link addess (default is
> 0x180000)],
You should use AC_HELP_STRING, and load-addr (or even load-address)
instead ld-addr.
> laden_address="$withval", laden_address=0x180000)
> test -z "$laden_address" && laden_address=0x180000
This test is superfluous. If the user doesn't specify an address with the
option, he loses.
In fact, it would be best if you could write an autoconf macro that does all
this for you in a generic way, that is then invoked by each of the configure
snippets:
HURD_LOAD_ADDRESS(laden, 0x180000)
With something like this in acinclude.m4:
AC_DEFUN(HURD_LOAD_ADDRESS,
[AC_ARG_WITH([$1-load-address],
AC_HELP_STRING([--with-$1-load-address],
[set $1 load address (default is $2)]),
hurd_$1_load_address=$withval, hurd_$1_load_address=$2)])
(untested).
Can you please work this out?
Thanks,
Marcus
--
`Rhubarb is no Egyptian god.' GNU http://www.gnu.org address@hidden
Marcus Brinkmann The Hurd http://www.gnu.org/software/hurd/
address@hidden
http://www.marcus-brinkmann.de/