[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] implement hurd_slab_destory and fix some small errors.
From: |
Marcus Brinkmann |
Subject: |
Re: [PATCH] implement hurd_slab_destory and fix some small errors. |
Date: |
Fri, 26 Mar 2004 02:01:55 +0100 |
User-agent: |
Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.3 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Thu, 25 Mar 2004 19:00:11 +0100,
Johan Rydberg wrote:
> There were some problems with the current implementation of the slab
> allocator. First of all, the `grow' function did not check the return
> value from the ctor callback. Second, there were no way to destory a
> slab space. Hopefully this patch fixes these problems. It is not
> tested at all, and please let me know if there are any major errors
> with the patch.
Modified version that you sent me (which cleans up the constructed
objects in case of an error) applied. Thanks!
> 2004-03-25 Johan Rydberg <address@hidden>
>
> * slab.c (grow): Release memory if constructor fails to initialize
> object. Return error value from constructor.
> (reap): Make function static. Do not take space lock.
> (hurd_slab_reap): Take space lock.
> (hurd_slab_destroy): Implement.