Re: [libmicrohttpd] {Spam?} {Spam?} sizeof(size_t)==4 on 32-bit systems and position in the datastream

[Christian Grothoff]

You are right, that is an issue.  I've fixed it largely as you suggested (some 
changes were required in places beyond the API, but I think I got all of 
them).

The change is in SVN 8196 and breaks backwards-compatibility with the previous 
API (starting with MHD_VERSION 0x00040001 as #defined in microhttpd.h) due to 
the use of uint64_t which is obviously not the same as "size_t".  I've also 
taken the opportunity to change some of our "unsigned int"'s to "size_t"'s in 
places where "size_t" is more appropriate.  A detailed comment describing each 
function changed is in the ChangeLog.

Best,

Christian

On Thursday 05 February 2009 07:23:24 am address@hidden wrote:
> On 32-bit systems size_t often defined as unsigned int, sizeof(size_t) ==
> 4.
>
> So, on such systems there is no posibility to set content size more than
> 4Gb in the MHD_create_response_from_callback() (in size arg) and
> to set datastream position more than 4Gb in MHD_ContentReaderCallback()
> (in pos arg).
> This is preventing MHD to serve large files such as
> DVD images, which can be 4.7 Gb in size, or some huge video file
> (what in the "age of HD video" is not so uncommon).
>
> I propose to change the definition of the "size" and "pos" to some
> explicite 64-bit type, e.g. uint64_t from stdint.h or something similar.
> Surely, all other logic in the MDH's internals, related to this
> definitions, should support this new 64-bit type.
>
> Thank you.