Re: [libmicrohttpd] How to close all upgraded connections when shutting down MHD_Daemon?

[silvioprog]

Dude, thanks for the explanation regarding union + bool/char, I did some tests and noticed this issue. Please ignore the sent patch. :-)

On Thu, May 4, 2017 at 11:29 AM, Evgeny Grin <address@hidden> wrote:

Same for "pending data".
Moreover MHD_DAEMON_INFO_PENDING_DATA is confusing and not correct.
Zero in data_already_pending doesn't mean that no data is pending. Zero
only means that "no data for immediately process". May be socket is not
ready for sending more data, but more data is pending.

And mapping "bool" to not bool is not correct. union MHD_DaemonInfo
doesn't have "bool" member and currently we do not want to expose "bool"
in public header.
On some platforms "bool" can be implemented as "char".

--
Best Wishes,
Evgeny Grin

On 04.05.2017 17:20, Christian Grothoff wrote:
> You forgot to update doc/libmicrohttpd.texi, otherwise looks OK even
> though I'm not convinced SHUTDOWN/QUESTCED are useful: an application
> can trivially track those itself, so these two are definitively just API
> bloat.
>
> On 05/04/2017 03:59 PM, silvioprog wrote:
>> Done. So dudes, what do you think about this attached patch?
>>

--

Silvio Clécio