[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libmicrohttpd] (GNUTLS_E_INTERRUPTED != res) checked twice
|
From: |
Christian Grothoff |
|
Subject: |
Re: [libmicrohttpd] (GNUTLS_E_INTERRUPTED != res) checked twice |
|
Date: |
Wed, 19 Dec 2018 00:07:59 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
You are indeed correct, fixed in 700f23d5..b7052c04.
Thanks for letting us know!
Happy hacking!
Christian
On 12/18/18 11:46 AM, Lasa Martxel wrote:
> Hello,
>
>
>
> I have found the following code in daemon.c file, lines 1449 to 1467:
>
>
>
> if (0 >= res)
>
> {
>
> if (GNUTLS_E_INTERRUPTED != res)
>
> {
>
> urh->app.celi &= ~MHD_EPOLL_STATE_WRITE_READY;
>
> if (GNUTLS_E_INTERRUPTED != res)
>
>
>
> (GNUTLS_E_INTERRUPTED != res) is checked twice.
>
>
>
> In the read part (a few lines above), GNUTLS_E_INTERRUPTED != res is
> checked first and then GNUTLS_E_AGAIN != res. It looks like something
> similar should be done here, but I’m not sure.
>
>
>
> Thanks,
>
> Martxel
>
signature.asc
Description: OpenPGP digital signature