[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libmicrohttpd] [PATCH] Fix more 'address already in use' issues
|
From: |
Tim Rühsen |
|
Subject: |
Re: [libmicrohttpd] [PATCH] Fix more 'address already in use' issues |
|
Date: |
Wed, 29 May 2019 09:51:09 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 5/28/19 9:03 PM, Evgeny Grin wrote:
> Hi Tim,
>
> Thanks for patches.
> However whole testsuite is not designed to be run in parallel.
> Testsuite individual tests use all available CPU cores so when used in
> parallel, tests could produce unpredictable wrong results.
Despite that, I wish you could consider merging the patches as they fix
an obvious issue.
Just as a suggestion, those "torture" tests (multi-threaded, I guess ?)
could go into a different directory. And then use .NOTPARALLEL or
'AUTOMAKE_OPTIONS = serial-tests' in Makefile.am.
Another option to just run the some tests not parallel with others is to
set up make targets (as dependencies for the other tests).
It would be nice to have that solved, as me (and other devs I know of)
have a make alias in their .bashrc like alias make='make -j$(nproc)'.
Regards, Tim
signature.asc
Description: OpenPGP digital signature