Re: [libmicrohttpd] [PATCH] Fix test_upgrade/test_upgrade_tls running in parallel

[Evgeny Grin]

30.05.2019 16:45, Tim Rühsen wrote:
>> Thanks for details.
>> I'll fix this case.
> Thank you !
Check updated git master, please.
>
>> However, it is not advisable to use any -Werror= flags for configure, as
>> it may break some tests.
>> For example, if you will use -Werror=extra-semi clang flag then you will
>> break most of compile and link tests.
>> I'd recommend you to run configure without any -Werror flags, but
>> redefine CGLAGS with -Werror parameters for make invocation.
>>
> My CFLAGS are
>
> ac_configure_args =  'CFLAGS=-g -Og -Wall -Wextra -Wall -Wextra
> -Wformat=2 -Walloc-zero -Walloca -Wbad-function-cast -Wcomments
> -Wdate-time -Wdouble-promotion -Wduplicated-branches -Wduplicated-cond
> -Werror-implicit-function-declaration -Wfloat-conversion -Wfloat-equal
> -Wformat -Wformat-signedness -Wformat-truncation -Winit-self
> -Winvalid-pch -Wjump-misses-init -Wlogical-op -Wmissing-declarations
> -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-prototypes
> -Wmultichar -Wnested-externs -Wnormalized -Wold-style-definition
> -Woverlength-strings -Wpedantic -Wpointer-arith -Wredundant-decls
> -Wscalar-storage-order -Wshift-overflow -Wstrict-prototypes
> -Wstringop-overflow -Wswitch-default -Wswitch-enum -Wundef
> -Wunused-const-variable -Wvariadic-macros -Wwrite-strings
> -Warray-bounds=2 -Wnormalized=nfc -Wshift-overflow=2
> -Wunused-const-variable=2 -Wformat-overflow=2 -Wformat-truncation=1
> -Wstringop-overflow=2 -fdiagnostics-color=always -Wno-cast-function-type'
>
> So there is this -Werror-implicit-function-declaration. The CFLAGS are
> automatically generated by using 'gcc -Q --help=warnings,C' and some
> scripting within a m4 file. This command lists
> -Werror-implicit-function-declaration for gcc-4.6 and higher. I wonder
> if this is a gcc bug that I run into - since only warnings have been
> requested.
Looks like a typo in GCC built-in help description.
Option '-Werror-implicit-function-declaration' (with minus sign)
actually must by '-Werror=implicit-function-declaration' (with equal
sign). When you request all warnings, this option is not filtered out by
'-Werror=' template and used as error flag.

-- 
Wishes,
Evgney

signature.asc
Description: OpenPGP digital signature