Re: [PATCH lbwww] Better instructions to create patches

[Adrien Bourmault]

Le 23/03/2023 à 02:43, Denis 'GNUtoo' Carikli a écrit :
> [...]

I submitted a v2 for this patch considering your review.

> As for using a coding style, in practice it helps a lot for code
> readability and easy patch rebasing, but:
> (1) I don't know any coding style for shell
> (2) in practice I found it really hard to enforce something like that
>      without automatic tools that can check it, and here I don't know any
>      for shell.
> (3) If we have some legacy code base, we'd need to do a painful
>      conversion to a new code style.
>
> I've put all I know in a wiki[2], so it probably needs some more
> research for shell. There are probably stuff around but we'd probably
> need to do more research to find good standards and tools.

Okay.

> Though for contributions we could probably at least try to ask people
> to limit the line length to 80 characters whenever possible and try to
> stay consistent with the rest of the file with regard to tap and spaces.

+1

> All that doesn't necessarily need to be in the same patch though.

Okay.

--
Adrien Bourmault
Trésorier de l'Association Libre en Communs
Associate member, Free Software Foundation
Elected member, XMPP Standards Foundation
GPG: aad6b069819e6979
-
Defend Richard M. Stallman ! <https://stallmansupport.org/>

OpenPGP_0xAAD6B069819E6979.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature