Re: Patches wrt to Tru64

[Gary V. Vaughan]

On Mon, Dec 18, 2000 at 05:15:22AM -0000, ANEESH KUMAR .K.V wrote:
> 
> >From: "Gary V. Vaughan" <address@hidden>
> >It looks like the bulk of your patch was applied already.  I have also
> >committed the change to the linker pass through flag to HEAD and
> >multi-language branches.
> 
> Hai ,
> 
> I  checked out the project from cvs today but didn't find this patch . This 
> one is acutally for supporting -export-symbols for cxx compiler on Tru64 box 
> .

This is completely different to your last patch.  In your earlier
email you said:

Index: libtool.m4
===================================================================
RCS file: /home/cvs/libtool/libtool.m4,v
retrieving revision 1.118
diff -u -r1.118 libtool.m4
--- libtool.m4  2000/09/30 05:28:23     1.118
+++ libtool.m4  2000/10/12 03:25:09
@@ -1341,6 +1341,11 @@
     else
       allow_undefined_flag=' -expect_unresolved \*'
       archive_cmds='$LD -shared${allow_undefined_flag} $libobjs $deplibs 
$linker_flags -msym -soname $soname `test -n "$verstring" && echo -set_version 
$verstring` -update_registry ${output_objdir}/so_locations -o $lib'
+
+        archive_expsym_cmds='for i in `cat $export_symbols`; do printf 
"-exported_symbol " >> $lib.exp; echo "\$i" >> $lib.exp; done; echo "-hidden">> 
$lib.exp~
+      $LD -shared${allow_undefined_flag} -input $lib.exp $linker_flags 
$libobjs $deplibs -soname $soname `test -n "$verstring" && echo -set_version 
$verstring` -update_registry ${objdir}/so_locations -o $lib~$rm $lib.exp'
+
+
     fi
     hardcode_libdir_flag_spec='${wl}-rpath ${wl}$libdir'
     hardcode_libdir_separator=:


Which is exactly the contents of the current libtool HEAD release, and
ltcf-c.sh in the libtool multi-language branch, without needing to
apply that patch.

Now you say:

Index: libtool/ltcf-cxx.sh
===================================================================
RCS file: /home/cvs/libtool/Attic/ltcf-cxx.sh,v
retrieving revision 1.1.2.25
diff -r1.1.2.25 ltcf-cxx.sh
399a400,402
>       archive_expsym_cmds='for i in `cat $export_symbols`; do printf 
>"-exported_symbol " >> $lib.exp; echo "\$i" >> $lib.exp; done; echo 
>"-hidden">> $lib.exp~
>        $CC -shared${allow_undefined_flag} $predep_objects $libobjs 
>$deplibs $postdep_objects $compiler_flags -msym -soname $soname -Wl,-input 
>-Wl,$lib.exp  `test -n "$verstring" && echo -set_version $verstring` 
>-update_registry ${objdir}/so_locations -o $lib~$rm $lib.exp'

...which is very different to what you asked for previously.  It seems
that you meant to ask for a patch to ltcf-cxx.sh in the first patch
but diffed the wrong files or something.  Could you please generate
your diffs with ``diff -c'' or ``diff -u'' against the HEAD and
multi-language branches, and resubmit them.

> I also found that that the flag used for passing linker option through the 
> compiler is also wrong . I am not sure whether it is getting used at any
> place  , but still i corrected it .

I made it this way in response to your last patch.  You said:

Index: libtool.m4
===================================================================
RCS file: /home/cvs/libtool/libtool.m4,v
retrieving revision 1.118
diff -u -r1.118 libtool.m4
--- libtool.m4  2000/09/30 05:28:23     1.118
+++ libtool.m4  2000/10/12 03:25:09
@@ -683,7 +683,7 @@
 
     osf3* | osf4* | osf5*)
       # All OSF/1 code is PIC.
-      ac_cv_prog_cc_wl='-Wl,'
+      ac_cv_prog_cc_wl='-WL,'
       ac_cv_prog_cc_static='-non_shared'
       ;;
 

And now you say:

710c713
<           ac_cv_prog_cc_wl='-WL,'
---
>           ac_cv_prog_cc_wl='-Wl,'

I am assuming it was correct before I applied your first patch, to I
have reverted to that state (or at least, I will when subversions
comes back up).  I'm afraid I can't make sense of the contents of the
patches you have sent so far =(O|

Please don't be disheartened.  You should read the submission
guidlines linked to from http://www.gnu.org/software/libtool.  You
need to update your local libtool directory to the latest contents of
CVS before generating a patch, and you must also be sure that the test
suite still passes (or at least that you don't introduce any
additional failures).  That done you can use ``cvs -z3 diff -u -p >>
libtool-patch'' and mail the file ``libtool-patch'' to this list.
Don't forget to check the patch by eye to ensure that it really does
contain the changes you intend -- just incase you are in the wrong
directory when you generate it or something.

Cheers,
        Gary.
-- 
  ___              _   ___   __              _         mailto: address@hidden
 / __|__ _ _ ___ _| | / / | / /_ _ _  _ __ _| |_  __ _ ___       address@hidden 
| (_ / _` | '_|// / |/ /| |/ / _` | || / _` | ' \/ _` | _ \
 \___\__,_|_|\_, /|___(_)___/\__,_|\_,_\__, |_||_\__,_|//_/
home page:  /___/                      /___/                  gpg public key:
http://www.oranda.demon.co.uk           http://www.oranda.demon.co.uk/key.asc