zsh fixed?

[Peter O'Gorman]

I was thinking of messing with the echo tests again, and was playing in 
zsh running the tests. I made a typo which turned out to be very 
interesting. I added "" around the test.
in zsh:
a=`echo \\\t`
echo $a
t
a="`echo \\\t`"
echo $a
\t
with bash they are both the same, the result is \t.

libtool make check results with zsh as /bin/sh on current libtool cvs:

25 of 100 tests failed

And with this patch:
1 of 105 tests failed

It still passed all tests with bash as /bin/sh on my (darwin-6.4) 
system.

Does anyone see any problems with this? (note that this is not a patch 
submission, it is an rfc). It will allow me to remove the zsh bits from 
the echo test and the test -z "${ZSH_VERSION}" from the darwin 
archive_cmds in libtool.m4.

Thanks,
Peter

Index: libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libtool.m4,v
retrieving revision 1.312
diff -u -d -b -w -r1.312 libtool.m4
--- libtool.m4  2 Apr 2003 16:44:37 -0000       1.312
+++ libtool.m4  3 Apr 2003 14:52:45 -0000
@@ -3890,10 +3890,10 @@
     old_postinstall_cmds | old_postuninstall_cmds | \
     sys_lib_search_path_spec | sys_lib_dlsearch_path_spec)
       # Double-quote double-evaled strings.
-      eval "lt_$var=\\\"\`\$echo \"X\$$var\" | \$Xsed -e 
\"\$double_quote_subst\" -e \"\$sed_quote_subst\" -e 
\"\$delay_variable_subst\"\`\\\""
+      eval "lt_$var=\"\\\"\`\$echo \"X\$$var\" | \$Xsed -e 
\"\$double_quote_subst\" -e \"\$sed_quote_subst\" -e 
\"\$delay_variable_subst\"\`\\\"\""
       ;;
     *)
-      eval "lt_$var=\\\"\`\$echo \"X\$$var\" | \$Xsed -e 
\"\$sed_quote_subst\"\`\\\""
+      eval "lt_$var=\"\\\"\`\$echo \"X\$$var\" | \$Xsed -e 
\"\$sed_quote_subst\"\`\\\"\""
       ;;
     esac
   done

zsh.diff.gz
Description: GNU Zip compressed data