libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: remove deprecated stuff from ltmain.in


From: Gary V. Vaughan
Subject: Re: remove deprecated stuff from ltmain.in
Date: Mon, 29 Sep 2003 13:38:00 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20030925 Thunderbird/0.3

Peter O'Gorman wrote:
This patch removes the inferring of the mode and the -allow-undefined
flag (well, it makes them errors).

Is it time? Okay to apply?

Yikes! It shows how long it is since I was paying attention, that I didn't even know that mode inference had been deprecated :-/

For -allow-undefined: Yes, please commit, but add a NEWS entry to the patch.

For mode inference: Not as it stands, I think there should be a convenient shorthand for using libtool at the command line. I suggest that if the mode is not specified, the first argument to libtool will be interpreted as the mode. Better yet, a left anchored unique substring from a valid mode name should be accepted (add this to ltmain.in just before option parsing proper):

    case $1 in
    compile|compil|compi|comp|com|co|o)
      shift; set -- --mode=compile ${1+"$@"}
      ;;
    execute|execut|execu|exec|exe|ex|e)
      shift; set -- --mode=execute ${1+"$@"}
      ;;
    install|instal|insta|inst|ins|in|i)
      shift; set -- --mode=install ${1+"$@"}
      ;;
    link|lin|li|l)
      shift; set -- --mode=link ${1+"$@"}
      ;;
    uninstall|uninstal|uninsta|uninst|unins|unin|uni|un|u)
      shift; set -- --mode=uninstall ${1+"$@"}
      ;;
    esac

Allow abit of time for people to disagree with me, otherwise I agree to the commit of the other part of your patch if the case statement above is also included. Oh, and NEWS will need updating again.

There are two separate commits in this mail, don't forget :-)

Cheers,
        Gary.
--
  ())_.  Gary V. Vaughan    gary@(lilith.warpmail.net|gnu.org)
  ( '/   Research Scientist http://www.oranda.demon.co.uk       ,_())____
  / )=   GNU Hacker         http://www.gnu.org/software/libtool  \'      `&
`(_~)_   Tech' Author       http://sources.redhat.com/autobook   =`---d__/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]